-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
price specification by user should match what miner has in their ask #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGWM -- not sure if it might need CLI helptext to be updated
What helptext?
|
The imaginary helptext that would explain what |
Reverted until we can figure out backwards compatibility: |
@@ -338,6 +338,8 @@ func (c *Client) ProposeStorageDeal(ctx context.Context, params storagemarket.Pr | |||
return nil, xerrors.Errorf("computing commP failed: %w", err) | |||
} | |||
|
|||
pricePerEpoch := big.Mul(big.NewInt(int64(pieceSize.Padded())), params.Price) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure params.Price
is per GB here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on how this gets into the actors proposal object, i don't think it is.
This was a poor bit of UX that required users to multiply their storage price by the padded size of their data in order to propose the correct thing to the miner.
price should always be specified in the same terms. Miners asks say price in FIL/GB/Epoch, and what the user types should match this.